Skip to content

Conversation

@ldionne
Copy link
Member

@ldionne ldionne commented Oct 31, 2025

Instead of always triggering the BuildKite pipeline and then determining whether there is anything to do, trigger it from the libc++ CI Github action. Since that Github action is only triggered when relevant files have been modified, this simplifies the triggering logic.

Importantly, it will also prevent all of the monorepo CI jobs from waiting on the Buildkite pipeline to report that there's nothing to do.

Instead of always triggering the BuildKite pipeline and then
determining whether there is anything to do, trigger it from
the libc++ CI Github action. Since that Github action is only
triggered when relevant files have been modified, this simplifies
the triggering logic.

Importantly, it will also prevent all of the monorepo CI jobs from
waiting on the Buildkite pipeline to report that there's nothing
to do.
@ldionne ldionne force-pushed the review/trigger-buildkite-via-actions branch from 0388383 to 5c0e607 Compare November 2, 2025 20:52
@ldionne ldionne force-pushed the review/trigger-buildkite-via-actions branch from 0f2e5d3 to 4ba7bc7 Compare November 3, 2025 19:22
@ldionne
Copy link
Member Author

ldionne commented Nov 4, 2025

Summary of what I tried and found here. I iterated on this in ldionne#6 after creating a copy of the normal libc++ pipeline at https://buildkite.com/llvm-project/ldionne-test-pipeline.

The basic issue is that you must disable the automatic Github integration for PRs, otherwise the pipeline gets triggered automatically and you don't get the availability to filter based on modified files.

However, once you turn that off, you can trigger a build using the buildkite/trigger-pipeline-action action, but there won't be status updates on the PR UI. Essentially, the pipeline starts building, but there is nothing showing that on the PR interface (ie the usual yellow "build pending" status isn't created). I looked into various ways to manually send notifications back from Buildkite to Github to update the status, but I don't think there is a way to do that without creating a Github app.

@ldionne ldionne closed this Nov 4, 2025
@ldionne ldionne deleted the review/trigger-buildkite-via-actions branch November 4, 2025 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant